[Qemu-devel] Re: [PATCH 1/6] Fix VMware VGA init call

[Anthony Liguori]

And attached is v2 which updates both uses of ram_size instead of just 
the one :-)

Regards,

Anthony Liguori

Anthony Liguori wrote:
> This was never corrected during the ram_alloc() conversion.
>
> Index: qemu/hw/pc.c
> ===================================================================
> --- qemu.orig/hw/pc.c   2008-02-01 10:01:47.000000000 -0600
> +++ qemu/hw/pc.c        2008-02-01 10:57:01.000000000 -0600
> @@ -869,7 +869,7 @@
>      } else if (vmsvga_enabled) {
>          if (pci_enabled)
>              pci_vmsvga_init(pci_bus, ds, phys_ram_base + ram_size,
> -                            ram_size, vga_ram_size);
> +                            vga_ram_addr, vga_ram_size);
>          else
>              fprintf(stderr, "%s: vmware_vga: no PCI bus\n", __FUNCTION__);
>      } else {
>   

Subject: [PATCH 1/6] Fix VMware VGA init call (v2)
Cc: Avi Kivity <address@hidden>
Cc: Fabrice Bellard <address@hidden>
Cc: Paul Brook <address@hidden>
Cc: address@hidden

This was never corrected during the ram_alloc() conversion.

Since v1, we update both uses of ram_size.

Index: qemu/hw/pc.c
===================================================================
--- qemu.orig/hw/pc.c   2008-02-01 16:21:40.000000000 -0600
+++ qemu/hw/pc.c        2008-02-01 16:22:04.000000000 -0600
@@ -868,8 +868,8 @@
         }
     } else if (vmsvga_enabled) {
         if (pci_enabled)
-            pci_vmsvga_init(pci_bus, ds, phys_ram_base + ram_size,
-                            ram_size, vga_ram_size);
+            pci_vmsvga_init(pci_bus, ds, phys_ram_base + vga_ram_size,
+                            vga_ram_addr, vga_ram_size);
         else
             fprintf(stderr, "%s: vmware_vga: no PCI bus\n", __FUNCTION__);
     } else {