Re: [Qemu-devel] [PATCH] Better version.rc patch

[Johannes Schindelin]

Hi,

On Fri, 8 Feb 2008, C.W. Betts wrote:

> This is a better patch to make qemu on Windows show info when you go 
> into properties.

It is _still_ a hassle to review your patch, since you did not inline it 
again.

So I will comment without quoting any of your patch, which will leave 
others guessing as to what we're talking about.

FILEVERSION and PRODUCTVERSION need to get a #define'd value, which you 
have to #define in ./configure in config-host.h, as I suggested already.

Also, it seems as you have yet another line which is commented out, with a 
comment "currently not working".  I'd appreciate it if it was left out, or 
fixed.

Hth,
Dscho