[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G suppor
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2) |
Date: |
Sun, 10 Feb 2008 14:59:32 +0000 |
User-agent: |
KMail/1.9.7 |
On Sunday 10 February 2008, Avi Kivity wrote:
> Paul Brook wrote:
> >>> as far as i remember it was used to address something with
> >>> cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE
> >>> or ~TARGET_PAGE_SIZE,
> >>>
> >>> the fact is that i dont know if it ever fixed anything
> >>
> >> It fixes TARGET_PAGE_MASK, defined one line downscreen.
> >
> > That doesn't really answer the question. What was wrong with the original
> > definition?
>
> There are many instances of ((physical address) & TARGET_PAGE_MASK)
> scattered throughout the code. With 64-bit physical addresses, this
> causes truncation.
No it doesn't. TARGET_PAGE_MASK will be sign extended to the width of
physical_address. This is why I asked for a concrete example of something
that broke.
Paul
- [Qemu-devel] [PATCH 1/6] Fix VMware VGA init call, (continued)
- [Qemu-devel] [PATCH 1/6] Fix VMware VGA init call, Anthony Liguori, 2008/02/01
- [Qemu-devel] [PATCH 3/6] SCI fixes (v2), Anthony Liguori, 2008/02/01
- [Qemu-devel] [PATCH 2/6] Use correct types to enable > 2G support (v2), Anthony Liguori, 2008/02/01
- [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Anthony Liguori, 2008/02/03
- [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Izik Eidus, 2008/02/04
- [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Anthony Liguori, 2008/02/04
- [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Avi Kivity, 2008/02/10
- Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Paul Brook, 2008/02/10
- Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Avi Kivity, 2008/02/10
- Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2),
Paul Brook <=
- Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2), Avi Kivity, 2008/02/10
[Qemu-devel] [PATCH 4/6] Fix daemonize options (v2), Anthony Liguori, 2008/02/01
[Qemu-devel] [PATCH 5/6] Tell BIOS about the number of CPUs (v2), Anthony Liguori, 2008/02/01
[Qemu-devel] [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface (v2), Anthony Liguori, 2008/02/01