Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

[Daniel Jacobowitz]

On Wed, Feb 13, 2008 at 04:52:22PM +0100, Marius Groeger wrote:
> On Wed, 13 Feb 2008, Daniel Jacobowitz wrote:
> 
> > On Wed, Feb 13, 2008 at 09:46:44AM +0100, Marius Groeger wrote:
> > >   if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK) &&
> > >      !ctx->singlestep_enabled) {

> > No, if you've gone to a different page without single step then you
> > don't need the debug trap.
> 
> Hm, so you mean betweeen the first "if .. !ctx->singlestep_enabled" 
> and the second one in the evaluation of ctx->singlestep_enabled 
> changes? What I meant is simply that the "else" clause already implies 
> that ctx->singlestep_enabled is true.

No it doesn't.

if (A && !B) {
   ...
} else {
   ...
}

The else block will be entered if !A, or if A && B.

-- 
Daniel Jacobowitz
CodeSourcery