[Qemu-devel] [PATCH] some functions declared () rather than (void)

[Ian Jackson]

There are a few functions which are declared using this syntax
  return_value function()
when in fact they take no arguments and so should be
  return_value function(void)

The former is either a pre-ANSI declaration with unspecified argument
types (which is usually inappropriate), or a mistake by someone more
familiar with C++ than C.

I haven't changed all of the cases, just the ones where it seemed
clear that it should be changed.

Thanks,
Ian.

Signed-off-by: Ian Jackson <address@hidden>

diff --git a/block-vvfat.c b/block-vvfat.c
index 7fe7e6a..c587bcf 100644
--- a/block-vvfat.c
+++ b/block-vvfat.c
@@ -53,7 +53,7 @@
 #define stderr STDERR
 FILE* stderr = NULL;
 
-static void checkpoint();
+static void checkpoint(void);
 
 #ifdef __MINGW32__
 void nonono(const char* file, int line, const char* msg) {
@@ -2811,7 +2811,7 @@ BlockDriver bdrv_vvfat = {
 };
 
 #ifdef DEBUG
-static void checkpoint() {
+static void checkpoint(void) {
     assert(((mapping_t*)array_get(&(vvv->mapping), 0))->end == 2);
     check1(vvv);
     check2(vvv);
diff --git a/darwin-user/qemu.h b/darwin-user/qemu.h
index 41b57f8..7240f82 100644
--- a/darwin-user/qemu.h
+++ b/darwin-user/qemu.h
@@ -113,7 +113,7 @@ extern int loglevel;
 extern FILE *logfile;
 
 /* commpage.c */
-void commpage_init();
+void commpage_init(void);
 void do_commpage(void *cpu_env, int num, uint32_t arg1, uint32_t arg2, 
uint32_t arg3,
                 uint32_t arg4, uint32_t arg5, uint32_t arg6, uint32_t arg7, 
uint32_t arg8);
 
diff --git a/darwin-user/syscall.c b/darwin-user/syscall.c
index f17e591..ae39f9a 100644
--- a/darwin-user/syscall.c
+++ b/darwin-user/syscall.c
@@ -417,7 +417,7 @@ long do_mach_syscall(void *cpu_env, int num, uint32_t arg1, 
uint32_t arg2, uint3
                 uint32_t arg4, uint32_t arg5, uint32_t arg6, uint32_t arg7,
                 uint32_t arg8)
 {
-    extern uint32_t mach_reply_port();
+    extern uint32_t mach_reply_port(void);
 
     long ret = 0;
 
@@ -551,7 +551,7 @@ long do_thread_syscall(void *cpu_env, int num, uint32_t 
arg1, uint32_t arg2, uin
                 uint32_t arg8)
 {
     extern uint32_t cthread_set_self(uint32_t);
-    extern uint32_t processor_facilities_used();
+    extern uint32_t processor_facilities_used(void);
     long ret = 0;
 
     arg1 = tswap32(arg1);
@@ -830,7 +830,7 @@ static inline void byteswap_timeval(struct timeval *t)
 }
 
 long do_unix_syscall_indirect(void *cpu_env, int num);
-long do_sync();
+long do_sync(void);
 long do_exit(uint32_t arg1);
 long do_getlogin(char *out, uint32_t size);
 long do_open(char * arg1, uint32_t arg2, uint32_t arg3);
@@ -996,7 +996,7 @@ long do_exit(uint32_t arg1)
     return -1;
 }
 
-long do_sync()
+long do_sync(void)
 {
     sync();
     return 0;
diff --git a/hw/alpha_palcode.c b/hw/alpha_palcode.c
index 3bd2c54..50ce92c 100644
--- a/hw/alpha_palcode.c
+++ b/hw/alpha_palcode.c
@@ -56,7 +56,7 @@ pal_handler_t pal_handlers[] = {
 
 #if 0
 /* One must explicitely check that the TB is valid and the FOE bit is reset */
-static void update_itb ()
+static void update_itb (void)
 {
     /* This writes into a temp register, not the actual one */
     mtpr(TB_TAG);
@@ -65,7 +65,7 @@ static void update_itb ()
     mtpr(ITB_PTE);
 }
 
-static void update_dtb ();
+static void update_dtb (void);
 {
     mtpr(TB_CTL);
     /* This write into a temp register, not the actual one */
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 7306cbd..c0fb78f 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1670,7 +1670,7 @@ void helper_cmpxchg8b(void)
     CC_SRC = eflags;
 }
 
-void helper_single_step()
+void helper_single_step(void)
 {
     env->dr[6] |= 0x4000;
     raise_exception(EXCP01_SSTP);
diff --git a/target-i386/svm.h b/target-i386/svm.h
index 982d054..f99f47e 100644
--- a/target-i386/svm.h
+++ b/target-i386/svm.h
@@ -323,7 +323,7 @@ struct __attribute__ ((__packed__)) vmcb {
 
 /* function references */
 
-void helper_stgi();
+void helper_stgi(void);
 void vmexit(uint64_t exit_code, uint64_t exit_info_1);
 int svm_check_intercept_param(uint32_t type, uint64_t param);
 static inline int svm_check_intercept(unsigned int type) {
diff --git a/vl.c b/vl.c
index ee3f26d..288f2cf 100644
--- a/vl.c
+++ b/vl.c
@@ -899,7 +899,7 @@ static struct qemu_alarm_timer alarm_timers[] = {
     {NULL, }
 };
 
-static void show_available_alarms()
+static void show_available_alarms(void)
 {
     int i;