[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fix ncurses output
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] fix ncurses output |
Date: |
Wed, 12 Mar 2008 01:34:04 +0100 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
On Mon, Feb 25, 2008 at 06:48:06PM +0100, Bernhard Kauer wrote:
> The ncurses console uses mvwaddchnstr() to print a line of output
> to a ncurses pad. Unfortunately this routine stops to print further
> chars if a zero-char is seen in the line. This has the effect that
> parts of a line are never redraw.
Do you have a simple testcase (program to run, code, ...). I have been
unable to reproduce this problem here.
> The following patch puts spaces instead of the zeros into the line-buffer.
> Please note that this change affects other consoles as well and is
> perhaps undesirable. Comments?
I am not sure replacing zeros into spaces is correct. Zeros are not
supposed to be displayed, contrary to spaces.
Aurelien
> Index: console.h
> --- console.h 10 Feb 2008 16:33:13 -0000 1.2
> +++ console.h 25 Feb 2008 17:25:53 -0000
> @@ -104,7 +104,8 @@
> typedef unsigned long console_ch_t;
> static inline void console_write_ch(console_ch_t *dest, uint32_t ch)
> {
> - cpu_to_le32wu((uint32_t *) dest, ch);
> + if (!(ch & 0xff)) ch = 0x20;
> + cpu_to_le32wu((uint32_t *) dest, ch);
> }
>
> typedef void (*vga_hw_update_ptr)(void *);
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' address@hidden | address@hidden
`- people.debian.org/~aurel32 | www.aurel32.net
- Re: [Qemu-devel] [PATCH] fix ncurses output,
Aurelien Jarno <=