[Qemu-devel] RE: [kvm-devel] [patch 17/24] QEMU/KVM: add cpu_unregister_io_memory and make io mem table index dynamic

[Amit Shah]

* Marcelo Tosatti wrote:

> On Tue, Mar 18, 2008 at 06:02:10PM +0530, Amit Shah wrote:
> > This patch broke -no-kvm-irqchip:

...

> Hi Amit,
>
> There is no need to zero io_mem_used since its in the BSS. The loop in
> io_mem_init() was meant to allocate the slots from 0 to 4, not free
> them.

Of course.

> So does the following fix the problem?
>
> diff --git a/qemu/exec.c b/qemu/exec.c
> index edeb21a..e5199cf 100644
> --- a/qemu/exec.c
> +++ b/qemu/exec.c
> @@ -2519,7 +2519,7 @@ static void io_mem_init(void)
>      cpu_register_io_memory(IO_MEM_UNASSIGNED >> IO_MEM_SHIFT,
> unassigned_mem_re     cpu_register_io_memory(IO_MEM_NOTDIRTY >>
> IO_MEM_SHIFT, error_mem_read, not     for (i=0; i<5; i++) -      
> io_mem_used[i] = 0;
> +        io_mem_used[i] = 1;
>
>  #if defined(CONFIG_SOFTMMU)
>      io_mem_watch = cpu_register_io_memory(-1, watch_mem_read,

Yes, it does. Thanks.