Re: [Qemu-devel] [PATCH] Asynchronous reliable and configurable cache flush

[Samuel Thibault]

Hello,

Oh, by the way, shouldn't this:

Ian Jackson, le Tue 01 Apr 2008 18:18:59 +0100, a écrit :
>      put_le16(p + 81, 0x16); /* conforms to ata5 */
> -    put_le16(p + 82, (1 << 14));
> +    /* 14=nop 5=write_cache */
> +    put_le16(p + 82, (1 << 14) | (1 << 5));
>      /* 13=flush_cache_ext,12=flush_cache,10=lba48 */

use s->write_cache instead of always 1?  Else when using hdparm -i one
would think that write cache is always enabled.

Samuel