|
| From: | Paul Brook |
| Subject: | Re: [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2) |
| Date: | Sun, 6 Apr 2008 22:41:07 -0500 |
| User-agent: | KMail/1.9.9 |
On Friday 04 April 2008 23:02:50 Anthony Liguori wrote: > uint32_t is the wrong type to use to represent physical addresses. >.... > /* XXX: temporary until new memory mapping API */ > -uint32_t cpu_get_physical_page_desc(target_phys_addr_t addr) > +ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr) The returned value is still a uint32_t. Changing the function prototype without fixing that is just deluding yourself. Paul
| [Prev in Thread] | Current Thread | [Next in Thread] |