qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Two display refresh timers


From: Ian Jackson
Subject: [Qemu-devel] Two display refresh timers
Date: Wed, 9 Apr 2008 18:03:08 +0100

Is there a particular reason why there are two separate bits of
machinery, and two call flows, for vga display updates ?

When using vnc, vnc.c sets a timer for regular calls to
vnc_update_client, which calls into vga.c to update the DisplayState
data array (and associated dirty flags) and sends updates as a result.

When using sdl, vl.c sets a timer for regular calls to dpy_refresh.
vnc displays have a NULL dpy_refresh.

It would seem more rational if there was only one call flow.  It
should probably be done by the output machinery, since that is what
knows about the desirable update frequency, flow control, etc.  So I
think dpy_refresh should be abolished and instead sdl.c should arrange
its own timer.

Ian.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]