qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/2] 8250: Customized base baudrate


From: Jan Kiszka
Subject: [Qemu-devel] Re: [PATCH 2/2] 8250: Customized base baudrate
Date: Mon, 14 Apr 2008 21:22:01 +0200
User-agent: Thunderbird 2.0.0.12 (X11/20080226)

andrzej zaborowski wrote:
> On 13/04/2008, Jan Kiszka <address@hidden> wrote:
>>  --- a/hw/omap1.c
>>  +++ b/hw/omap1.c
>>  @@ -1734,7 +1734,8 @@ struct omap_uart_s *omap_uart_init(targe
>>      struct omap_uart_s *s = (struct omap_uart_s *)
>>              qemu_mallocz(sizeof(struct omap_uart_s));
>>      if (chr)
>>  -        s->serial = serial_mm_init(base, 2, irq, chr, 1);
>>  +        s->serial =
>>  +            serial_mm_init(base, 2, irq, omap_clk_getrate(clk)/16, chr, 1);
> 
> Yes, this should be correct.

While typing those line I wondered if it is possible and reasonable that
a guest changes this clock rate during runtime? In that case, the
perfect, but probably much more complex solution would be to track those
changes also with the serial emulation...

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]