qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] Reboot CPU on triple fault


From: Kevin Wolf
Subject: Re: [Qemu-devel] Re: [PATCH] Reboot CPU on triple fault
Date: Wed, 16 Apr 2008 10:37:04 +0200
User-agent: Thunderbird 1.5.0.8 (X11/20060911)

Paul Brook schrieb:
>> +    if (env->old_exception == EXCP08_DBLE) {
>> +        fprintf(stderr, "qemu: warning: triple fault\n");
> 
> IMHO There's no reason to print a message to stderr. This is all well defined 
> behavior, and the accepted way of exiting from 286 protected mode.

How many users does qemu have who need triple faults to exit from 286
Protected Mode? And how many users does it have who don't use triple
faults (yes, it's called a fault, not a PM exiting feature)
intentionally but might want the message and dumps for debugging?
Personally I suspect that a great majority belongs to the latter case.

And honestly, a message on stderr really shouldn't hurt those 286 folks.
They are even getting the reset they want from this patch.

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]