Re: [Qemu-devel] Re: [PATCH] x86: Reboot CPU on triple fault - Version 4

[Anthony Liguori]

Kevin Wolf wrote:
> Anthony Liguori schrieb:
>   
> > It's not a question of whether it's logged, it's a question of whether
> > it gets logged *specially*.  That's the crux of the discussion here.  My
> > argument is that triple faults are not sufficiently special that they
> > warrant *special* logging.
> >     
>
> I think CPU resets are special enough indeed. Obviously there _are_ use
> cases for this option and nobody who doesn't turn it on intentionally
> could ever get hurt by it. So what is your problem with it?
>   

You're missing my whole point.  v4 spewed stuff to stderr.  That's the 
problem I had.

> Honestly, it is ridiculous that we keep arguing about log messages while
> the main thing changed by the patch is the introduction of the correct
> CPU reset. I suspect we would never have discussed all these loglevel
> things if the latest patch wouldn't have been submitted as answer on a
> (not even working) patch which tried to remove the log...
>   

The patch still isn't right but it's close.  Logging events to logfile 
is fine.  It's logging to stderr that was problematic.

Regards,

Anthony Liguori

> Kevin
>
>
>