Re: [Qemu-devel] [PATCH] Set memory size per machine

[andrzej zaborowski]

On 20/04/2008, Blue Swirl <address@hidden> wrote:
> On 4/20/08, andrzej zaborowski <address@hidden> wrote:
>  > This patch lets a machine decide on the amount of space it'll use in
>  >  phys_ram_base in addition to that specified with "-m", default is
>  >  zero.  Currently that amount was the maximum of BIOS size + VGA RAM
>  >  size over all machines of all archs, and that was not enough for the
>  >  MusicPal and even if extended it may be not enough for a machine
>  >  supported in the future.
>  >
>  >  This also lets a machine OR the specified value with a RAMSIZE_FIXED
>  >  flag to indicate that it ignores the value given with "-m" (true for
>  >  almost half of the machines in qemu).
>
> In addition to minimum, higher level code could handle the maximum
>  memory size supported, like sun4m.c does currently. Then I'd use
>  ram_min and ram_max or something similar.

ram_require doesn't set a minimum for the "-m" value, this value is
passed as is to machine->init.  It only set the maximum RAM the
machine can use in addition to that specified with "-m".

I can add ram_min and ram_max but that would as far as I can tell be
used only by sun4m.c at the moment.

>
>  >  +#define RAMSIZE_FIXED  (1 << 0)
>  >  +    size_t ram_require;
>  >  +    const char *boot_letters;
>
> boot_letters?

Oops, this was an idea I gave up (for this patch) for QEMUMachine to
optionally specify allowed -boot values against main() could validate.

Regards
-- 
Please do not print this email unless absolutely necessary. Spread
environmental awareness.