Re: [Qemu-devel] [PATCH] Add -display option

[Daniel P. Berrange]

On Sun, Apr 20, 2008 at 05:01:27PM -0500, Anthony Liguori wrote:
> Sebastian Herbszt wrote:
> >>I would better name it -display, as not all computers have 
> >>VGA-compatible cards.

> >+                break;
> >+            case QEMU_OPTION_display:
> >+                if (!strcmp(optarg, "cirrus")) {
> >+                    cirrus_vga_enabled = 1;
> >+                    vmsvga_enabled = 0;
> >+                } else if (!strcmp(optarg, "std")) {
> >+                    cirrus_vga_enabled = 0;
> >+                    vmsvga_enabled = 0;
> >+                } else if (!strcmp(optarg, "vmware")) {
> >+                    cirrus_vga_enabled = 0;
> >+                    vmsvga_enabled = 1;
> >+                } else if (!strcmp(optarg, "none")) {
> >+                    serial_devices[0] = "stdio";
> >+                    parallel_devices[0] = "null";
> >+                    monitor_device = "stdio";
> >+                    nographic = 1;
> 
> I don't think -display none should be a synonym for -nographic.  It 
> should just suppress the creation of a VGA device.  If a platform 
> doesn't support that, it should raise an error.

I agree - its rather unfortunate that -nographic changes the default
settings for serial / parallel devices - it makes it troublesome to 
launch QEMU with a predictable config. Having 'none' merely supress
the VGA device would be preferrable behaviour.

It is certainly nice from a libvirt point of view to have a generic 
flag -display like this.

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|