qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [4262] IO ports registration errors are fatal errors.


From: Andrzej Zaborowski
Subject: [Qemu-devel] [4262] IO ports registration errors are fatal errors.
Date: Sat, 26 Apr 2008 21:11:23 +0000

Revision: 4262
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4262
Author:   balrog
Date:     2008-04-26 21:11:22 +0000 (Sat, 26 Apr 2008)

Log Message:
-----------
IO ports registration errors are fatal errors.

Revert previous change that shouldn't have gone in alone (or at all).

Modified Paths:
--------------
    trunk/vl.c

Modified: trunk/vl.c
===================================================================
--- trunk/vl.c  2008-04-26 16:04:29 UTC (rev 4261)
+++ trunk/vl.c  2008-04-26 21:11:22 UTC (rev 4262)
@@ -324,13 +324,13 @@
     } else if (size == 4) {
         bsize = 2;
     } else {
-        fprintf(stderr, "register_ioport_read: invalid size\n");
+        hw_error("register_ioport_read: invalid size");
         return -1;
     }
     for(i = start; i < start + length; i += size) {
         ioport_read_table[bsize][i] = func;
         if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
-            fprintf(stderr, "register_ioport_read: invalid opaque\n");
+            hw_error("register_ioport_read: invalid opaque");
         ioport_opaque[i] = opaque;
     }
     return 0;
@@ -349,15 +349,13 @@
     } else if (size == 4) {
         bsize = 2;
     } else {
-        fprintf(stderr, "register_ioport_write: invalid size\n");
+        hw_error("register_ioport_write: invalid size");
         return -1;
     }
     for(i = start; i < start + length; i += size) {
         ioport_write_table[bsize][i] = func;
-        if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque) {
-            fprintf(stderr, "register_ioport_write: invalid opaque\n");
-            return -1;
-        }
+        if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
+            hw_error("register_ioport_write: invalid opaque");
         ioport_opaque[i] = opaque;
     }
     return 0;






reply via email to

[Prev in Thread] Current Thread [Next in Thread]