Re: [Qemu-devel] [PATCH] configure: silence test for brlapi

[Ben Taylor]

On Sat, May 3, 2008 at 7:48 AM, Samuel Thibault
<address@hidden> wrote:
> Ben Taylor, le Sat 03 May 2008 07:42:54 -0400, a écrit :
>
> > On Solaris, I found that the configure code tested the 32-bit bit version
>  > while on 64-bit, and then it failed linking qemu-img, because Sun didn't
>  > deliver a 64-bit version of libbrlapi.
>  >
>  > Adding ${ARCH_CFLAGS} to the test caused it to do the right thing.
>
>  Oh, you mean the patch below?
>
>  Samuel
>
>  Index: configure
>  ===================================================================
>  --- configure   (révision 4294)
>  +++ configure   (copie de travail)
>  @@ -733,7 +733,7 @@
>   #include <brlapi.h>
>   int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }
>   EOF
>  -    if $cc -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.log 
> ; then
>  +    if $cc ${ARCH_CFLAGS} -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> 
> /tmp/qemu-$$-brlapi.log ; then
>             brlapi=yes
>      fi # brlapi compile test
>   fi # -z $brlapi

looks exactly like what I did.  (I know this sort of works around a Solaris bug,
but it should compile to the right architecture regardless)

Thanks,

Ben