[Qemu-devel] [PATCH 5/5] ppc: fix crash in ppc system single step support

[Jason Wessel]

There was a bogus case where two system debug ops get generated.  This
patch removes the broken system debug op. This was a left over after
making some changes to correctly generate debug ops on branch
operations inside gen_goto_tb();

The test case against this patch is to turn on single stepping with
timers, boot a linux kernel, set a breakpoint a do_fork and in gdb
execute "si 3000".  Then qemu-system-ppc will fault executing a debug
op, which should not have been executed.

Signed-off-by: Jason Wessel <address@hidden>
---
 target-ppc/translate.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 4e71614..45da869 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -3002,10 +3002,6 @@ static always_inline void gen_bcond (DisasContext *ctx, 
int type)
 #endif
             gen_op_btest_T1(ctx->nip);
     no_test:
-        if (ctx->singlestep_enabled & GDBSTUB_SINGLE_STEP) {
-            gen_update_nip(ctx, ctx->nip);
-            gen_op_debug();
-        }
         tcg_gen_exit_tb(0);
     }
 }
-- 
1.5.5.1