Re: [Qemu-devel] [PATCH] Capture network traffic

[Balazs Attila-Mihaly \(Cd-MaN\)]

First of all, I would like to thank you for taking the time to look over my 
patch. Sorry for not getting back to you sooner. I fixed most the mentioned 
issues and attached a diff which should apply cleanly to the current SVN HEAD.

> You can't cast the result of get_param_value() to char *
Fixed (I don't know what as was thinking...)

> Also I'm sure the use of asprintf() will upset the non-Linux-or-BSD users. 
AFAIK asprintf is quite standard (I know for a fact for example that the VC 
libraries implement it) and it is already used in the codebase. Are there known 
issues with it under some platforms? If so, shouldn't we create a wrapper 
function / emulation for it?

> I don't think you need to check for memory allocation failures (the message 
> will not display anyway in such case, because monitor allocates memory for 
> that).
Ok, I replaced it with exit(1), since I consider failure of memory allocation a 
major failure. Is this approach correct? Should I use a different exit code so 
that the user can identify the source of the failure?

> It will be nice if you can remove stray spaces on end of lines/empty lines.
Done. The perl script I hacked together for this can be downloaded from 
http://hype.free.googlepages.com/clean.pl in case anyone else needs it.

> The PCAPHeader struct probably should have a __packed__ attribute.
Good catch, I removed them

I also updated the documentation, although I'm not sure if I used the correct 
markup, so please check.

Best regards.



      __________________________________________________________
Sent from Yahoo! Mail.
A Smarter Email http://uk.docs.yahoo.com/nowyoucan.html

vlan_capture.diff
Description: Text Data