qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_D


From: Jamie Lokier
Subject: Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_DIRECT)
Date: Wed, 21 May 2008 00:13:03 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

Laurent Vivier wrote:
> Sector unaligned guest offset are converted to sector aligned offset.

The guest cannot give a sector unaligned offset.  How can it?  It
specifies offset in sectors, through the IDE or SCSI interfaces.

> Sector aligned guest offset are written as is.
> 
> And as we use O_DIRECT and aligned offset and data count I think we
> increase disk integrity (regarding the case without O_DIRECT and without
> aligned access...), so we should document the case without O_DIRECT use,
> not the case with O_DIRECT use...

That's fine, for direct-mapped formats.  I'm thinking of qcow format
etc. where guest aligned writes are sometimes translated to unaligned
(is this even true?).

-- Jamie




reply via email to

[Prev in Thread] Current Thread [Next in Thread]