|
From: | Kevin Wolf |
Subject: | Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_DIRECT) |
Date: | Wed, 21 May 2008 10:24:31 +0200 |
User-agent: | Thunderbird 2.0.0.12 (X11/20071114) |
Anthony Liguori schrieb:
I don't think it's that important to try and guess the right alignment size, 512 is probably usually sufficient, but spreading alignment requirements of 512 throughout QEMU code is a bad idea because this is something that's very hardware/OS specific.
So better introduce a #define in block.h?
For people that care about data integrity, we should be using O_SYNC, not O_DIRECT anyway.
Should we implement an option for O_SYNC then? (not in this patch, of course)
Kevin
[Prev in Thread] | Current Thread | [Next in Thread] |