[Qemu-devel] Re: [PATCH 1/3] simplify cpu_exec

[Anthony Liguori]

Glauber Costa wrote:
> This is a first attempt to simplify cpu_exec(): it has simply
> too many ifdefs, which is not a very good practice at all.
>
> Following some work I've already posted in the past, I'm moving the 
> target-based ifdefs to target-xxx/helper.c, encapsuled into 
> relevant functions.
>   

This is a very good thing to do.  My only suggestion would be to use a 
name that was a bit more meaningful that cpu_pre_exec().  These hooks 
seem to be loading and putting flag values for each architecture so 
something like cpu_exec_load_flags() and cpu_exec_put_flags() may be 
more meaningful.

Regards,

Anthony Liguori