qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 3/3] use halted attribute for i386 too.


From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH 3/3] use halted attribute for i386 too.
Date: Wed, 21 May 2008 17:08:57 -0500
User-agent: Thunderbird 2.0.0.14 (X11/20080501)

Glauber Costa wrote:
Unlike other architectures, i386 lacked a "halted" attribute, going
with a flag into hflags. By using the halted attribute, we can make
the code look like more other architectures, and simplify the code in
some instances. In this commit, we make the code for info_cpus simpler
in monitor.c

In the future, it would be better not to include both the halted change and the IP accessor in the same function. Plus, I'm not sure that accessor really should be doing the formating. eip will always be of type target_ulong so it just needs a #define for the printf formating (which is what the code does today).

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]