Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec

[Fabrice Bellard]

Glauber Costa wrote:
> This is a first attempt to simplify cpu_exec(): it has simply
> too many ifdefs, which is not a very good practice at all.
>
> Following some work I've already posted in the past, I'm moving the target-b
> ifdefs to target-xxx/helper.c, encapsuled into relevant functions.

OK for that, except that the naming is confusing because the related 
functions may not deal with the "flags". cpu_env_to_exec() and 
cpu_exec_to_env() might be better. Moreover, using inline functions (in 
exec.h) should be better.

Fabrice.