Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too.

[Fabrice Bellard]

Glauber Costa wrote:
> On Tue, May 27, 2008 at 12:34 PM, Fabrice Bellard <address@hidden> wrote:
>> Glauber Costa wrote:
>>> Unlike other architectures, i386 lacked a "halted" attribute, going
>>> with a flag into hflags. By using the halted attribute, we can make
>>> the code look like more other architectures, and simplify the code in
>>> some instances. In this commit, we make the code for info_cpus simpler
>>> in monitor.c
>> Good for the I386 halted attribute, as it was a mistake to put in in the
>> hflags. For the memory, hflags should contain only parts of the CPU state
>> known at translation time and should be equal to tb->flags. Most CPUs
>> (including x86 !) do not follow this sane rule.
> 
> What about HF_GIF_MASK? It looks like another case of something that
> is mistakenly put into hflags. What do you say?

This is true for: HF_GIF_MASK, HF_HIF_MASK, HF_NMI_MASK.

Fabrice.