qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/6] Simplify cpu_exec - spin 3


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH 0/6] Simplify cpu_exec - spin 3
Date: Wed, 28 May 2008 15:25:10 +0100
User-agent: KMail/1.9.9

On Wednesday 28 May 2008, Glauber Costa wrote:
> Hi guys,
>
> here's a new spin of the patches I sent yesterday. It basically merges the
> comments I received, and adapts to the current state of the svn tree.
> Also, as Fabrice said multiple times inlining would be better, I'm taking
> a new approach, and instead of defining functions, I'm defining empty
> macros (for the general case), and archictectures that need it can then
> override. It results in substantially less code.

I'm not so sure this is a good idea. IMHO using macros to implement functions 
is ugly. That's what inline functions are for :-)

Providing a default implementation is also a fairly suspect idea. When adding 
a new target I like that we generate an error error when I forget to populate 
all of the target specific routines. The same applies when making changes to 
generic code, you're forced to go through every target and update them.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]