Re: [Qemu-devel] [4632] Copy siginfo.si_code.

[Erik de Castro Lopo]

Paul Brook wrote:

> Revision: 4632
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4632
> Author:   pbrook
> Date:     2008-05-30 22:57:20 +0000 (Fri, 30 May 2008)
> 
> Log Message:
> -----------
> Copy siginfo.si_code.
> 
> Modified Paths:
> --------------
>     trunk/linux-user/signal.c

Sorry Paul, this commit broke the build.

> ===================================================================
> --- trunk/linux-user/signal.c 2008-05-30 22:37:07 UTC (rev 4631)
> +++ trunk/linux-user/signal.c 2008-05-30 22:57:20 UTC (rev 4632)
> @@ -216,7 +216,7 @@
>      sig = host_to_target_signal(info->si_signo);
>      tinfo->si_signo = sig;
>      tinfo->si_errno = 0;
> -    tinfo->si_code = 0;
> +    tinfo->si_code = info.si_code;

That is definitely not right. According to the code 4 lines earlier,
info is a pointer and you a treating it like a struct.

Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"C++ is the only current language making COBOL look good."
-- Bertrand Meyer