Re: [Qemu-devel] Re: [PATCH 0/5] Debugger enhancements

[Fabrice Bellard]

Jan Kiszka wrote:
> Fabrice Bellard wrote:
>> Hi,
>>
>> I cannot accept the patches for several reasons:
>>
>> 1) You mix cosmetic and functional patches.
> 
> Do you have specific hunks in mind? I'm a bit blind ATM, not seeing
> where I changed coding style or naming for cosmetic reasons.

You renammed mem_write_pc and mem_write_vaddr.

BTW, why did you add 'len' and 'type' parameters to breakpoints ?

I don't think it is a good idea to say that breakpoints/watchpoints
apply to all processors. Such behavior should be handled at a higher level.

It would also be interesting if the watchpoint/breakpoint implementation
could be used to implement CPU watchpoints and breakpoints (I am
thinking about the x86 DRx registers here).

Fabrice.