qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] get qemu to compile as 64-bit on Mac


From: Johannes Schindelin
Subject: Re: [Qemu-devel] [PATCH] get qemu to compile as 64-bit on Mac
Date: Mon, 2 Jun 2008 23:44:32 +0100 (BST)
User-agent: Alpine 1.00 (DEB 882 2007-12-20)

Hi,

On Mon, 2 Jun 2008, C.W. Betts wrote:

> Index: dyngen-exec.h
> ===================================================================
> --- dyngen-exec.h     (revision 4654)
> +++ dyngen-exec.h     (working copy)
> @@ -36,7 +36,7 @@
> typedef unsigned short uint16_t;
> typedef unsigned int uint32_t;
> // Linux/Sparc64 defines uint64_t
> -#if !(defined (__sparc_v9__) && defined(__linux__))
> +#if !(defined (__sparc_v9__) && defined(__linux__)) && !(defined(__APPLE__)
> && defined(__x86_64__))
> /* XXX may be done for all 64 bits targets ? */

This comment can go now, right?

> ===================================================================
> --- host-utils.h      (revision 4654)
> +++ host-utils.h      (working copy)
> @@ -23,6 +23,8 @@
>  * THE SOFTWARE.
>  */
> 
> +#include "osdep.h"
> +
> #if defined(__x86_64__)
> #define __HAVE_FAST_MULU64__
> static always_inline void mulu64 (uint64_t *plow, uint64_t *phigh,

BTW I guess that your patch is white-space damaged, i.e. cannot be applied 
as-is.

> +#ifndef __APPLE__
> +//Apple has this already defined, this would just mess things up
> #define inline always_inline
> +#endif

Would it not make more sense to say

#ifndef inline

Hmm?

Ciao,
Dscho





reply via email to

[Prev in Thread] Current Thread [Next in Thread]