Re: [Qemu-devel] Re: PATCH: Secure TLS encrypted authentication for VNC

[Daniel P. Berrange]

On Tue, Jun 03, 2008 at 07:48:10PM +0100, Stewart Becker wrote:
> On Tue, 2008-06-03 at 12:31 +0200, Peter Rosin wrote:
> > Hi!
> > 
> > Sorry for the response to this old post, but since it seems to be the
> > best reference for the VeNCrypt protocol on the web, I don't feel too
> > bad. Hopefully I got the message-id correct so that this post is
> > properly linked.
> > 
> 
> <snip>
> 
> > I would like to point out that vencserver seems to be sending an
> > extra U8 (== 0x01. Is that a boolean? 0x00 means failure?) before
> > the SSL/TLS handshake is started. The QEMU implementation does
> > this also, so the bug is clearly in this "spec". This also affects
> > sub-types 258, 259, 260, 261 and 262.
> 
> It's been a while since I looked at it, and don't have time immediately
> to check it in detail, but I think that this is the SecurityResult
> message as detailed in section 6.1.3 of the RFB specification.
> Re-reading it, I could probably have been more clear in my mail to Dan
> about where the VenCrypt extension rejoins the RFB protocol.  The reason
> that I put this in the extension code instead of the "main" VNC code is
> that only the extension knows whether the success of failure message
> should be sent.

When I wrote the code I checked the interoperability of QEMU against the 
VeNCrypt client, and the GTK-VNC  client agains the VeNCrypt server and
QEMU server, so the impl is the defacto spec :-)

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|