qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] Enhance sendkey with key hold time


From: Bernhard Fischer
Subject: Re: [Qemu-devel] [PATCH 2/2] Enhance sendkey with key hold time
Date: Wed, 4 Jun 2008 15:25:56 +0200
User-agent: Mutt/1.5.17+20080114 (2008-01-14)

On Wed, Jun 04, 2008 at 12:16:48PM +0200, andrzej zaborowski wrote:
>On 22/05/2008, Jan Kiszka <address@hidden> wrote:

>>  +static void release_keys(void *opaque)
>>  +{
>>  +    int keycode;
>>  +
>>  +    while (nb_pending_keycodes > 0) {

Perhaps just doing a post decrement on the nb_pending would be cleaner.

>>  +        keycode = keycodes[nb_pending_keycodes-1];
>>  +        if (keycode & 0x80)
>>  +            kbd_put_keycode(0xe0);
>>  +        kbd_put_keycode(keycode | 0x80);
>>  +        nb_pending_keycodes--;
>>  +    }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]