Re: [Qemu-devel] [PATCH] VMRUN should store the RIP after the instruction

[Anthony Liguori]

Alexander Graf wrote:
> On Jun 4, 2008, at 6:13 PM, Anthony Liguori wrote:
>
> > Alexander Graf wrote:
> > > VMRUN stores the IP which is used to return to the instruction after 
> > > the VMRUN in case of a VMEXIT. Due to recent changes, this does not 
> > > happen anymore and a VMEXIT simply returns to the VMRUN instruction.
> > >
> > > Alex
> >
> > The open-coded  + 3 bothers me.  Are there any circumstances that a 
> > prefix could be used with vmrun that would change the instruction 
> > length?  vmrun doesn't appear to be affected by prefixes but I don't 
> > see anything in the AMD manual specifically forbidding it.
>
> This is true and it bothers me as well. I am open to suggestions how 
> to receive the IP after the instruction that is about to be executed. 
> Probably this could be done in translate.c?

Looks like Fabrice's commit handles it nicely.

Regards,

Anthony Liguori

> Alex