Re: [Qemu-devel] Re: [PATCH] TC6393xb update: support system features

[Paul Brook]

On Monday 09 June 2008, andrzej zaborowski wrote:
> Hi,
>
> On 08/06/2008, Dmitry Baryshkov <address@hidden> wrote:
> > Any comments about this? TC6393xb is a multifunctional device as found
> >  in tosa or some toshibe e-series PDAs. And this provides some partial
> >  emulation of it's features.
>
> Committed, thanks.  Perhaps it's good to have at least a short license
> notice 

Licence notes and at least basic copyright information should definitely be 
required.

> and a note on what the device does or who produces it. I think 
> it's not a policy though.

I'd also strongly recommend that these be added.  I find it very useful to 
have a short comment saying exactly what device we're trying to emulate.

> +/* vim:set shiftwidth=4 ts=4 et: */

We can loose this though.

Paul