[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Use standard header for offsetof
From: |
Ian Jackson |
Subject: |
Re: [Qemu-devel] [PATCH] Use standard header for offsetof |
Date: |
Mon, 9 Jun 2008 11:30:19 +0100 |
Andreas Färber writes ("Re: [Qemu-devel] [PATCH] Use standard header for
offsetof"):
> Am 06.06.2008 um 21:44 schrieb Stefan Weil:
> > Qemu has no clear strategy for header file inclusion: qemu-common.h
> > is used by many source files and includes stdio.h,
> > but some files (for example osdep.h) include both qemu-common.h and
> > stdio.h.
>
> Iirc, qemu-common.h is still relatively new. If you noticed duplicate
> inclusions, those may be for "historic" reasons, so you could provide
> a patch eliminating them.
If qemu-common.h is the new approach, then perhaps Stefan should
resubmit a version of his patch to add <stddef.h> to qemu-common.h,
rather than to all of the .c files which use offsetof ?
Ian.