Re: [Qemu-devel] [PATCH] Do not redefine DEFAULT_NETWORK_{, DOWN_}SCRIPT

[Anthony Liguori]

Ian Jackson wrote:
> With this change it is possible to change the default network script
> with a change to CPPFLAGS or a suitable config.h, for example
>   -DDEFAULT_NETWORK_SCRIPT='"/path/to/some/script/of/mine/ifup"' \
>   -DDEFAULT_NETWORK_DOWN_SCRIPT='"/path/to/some/script/of/mine/ifdown"'
>   

This is a good idea, but I think it should be something that is 
specified in ./configure.

Regards,

Anthony Liguori

> My patch assumes that you'll want to override both defaults, or
> neither.
>
> Signed-off-by: Ian Jackson <address@hidden>
>
> ---
>  vl.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index f1d92c1..229b536 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -131,8 +131,10 @@ int inet_aton(const char *cp, struct in_addr *ia);
>  
>  #include "exec-all.h"
>  
> +#ifndef DEFAULT_NETWORK_SCRIPT
>  #define DEFAULT_NETWORK_SCRIPT "/etc/qemu-ifup"
>  #define DEFAULT_NETWORK_DOWN_SCRIPT "/etc/qemu-ifdown"
> +#endif
>  #ifdef __sun__
>  #define SMBD_COMMAND "/usr/sfw/sbin/smbd"
>  #else
>