qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ARM: fix CPS instruction


From: Laurent Desnogues
Subject: Re: [Qemu-devel] [PATCH] ARM: fix CPS instruction
Date: Thu, 12 Jun 2008 21:58:53 +0200

On Thu, Jun 12, 2008 at 9:17 PM, Vincent Palatin
<address@hidden> wrote:
> I attach a patch with 2 fixes for the ARMv6 instruction "CPS".
> According to ARM Reference Manual (DDI0100 A4.1.16),
> bit 5 is fixed to 0 (bit 4 is the MSB of the mode), so the instruction mask
> should be  0x0ff10020 not 0x0ff10010.
> Besides, mmod flag is bit 17 (b14 is SBZ)

Both corrections are correct.

I quickly cheched the other 2 cps instrcutions (Thumb 16 & 32 bit);
they look correct.

Nice catch :)


Laurent




reply via email to

[Prev in Thread] Current Thread [Next in Thread]