|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH] New scriptarg=... -net parameter allows passing of an argument |
Date: | Fri, 13 Jun 2008 00:26:38 +0300 |
User-agent: | Thunderbird 2.0.0.14 (X11/20080501) |
Anthony Liguori wrote:
Ian Jackson wrote:Previously, network scripts would have to do all of their work based only on the script name and interface name. If the script's behaviour is supposed to be different for different network interfaces this might involve constructing a special script for each interface with the associated need to delete it etc.env args should get passed down to the script although I can see an argument for being able to specify this in -net. My only suggestion would be to use an env arg instead of "$2" as it will make it easier to extend in the future.
Environment variables are global, whereas scriptarg is per-interface. Consider the case where scriptarg denotes the bridge name we want the interface to attach to.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
[Prev in Thread] | Current Thread | [Next in Thread] |