Re: [Qemu-devel] [PATCH] block-vvfat.c - fix is_free predicate

[Johannes Schindelin]

Hi,

On Thu, 26 Jun 2008, Tristan Gingold wrote:

> the current definition of is_free is not correct.  In particular, a new 
> file can be created with no attributes set.

This explanation is not good enough.

According to the only documentation I had quickly at hand, Wikipedia, 0x40 
is an attribute for a device, which is never found on disk, especially in 
our implementation.  0x80 is unused.  So your "& 0xc0" check seems to be 
totally bogus, suggesting that we use this kind of attributes anywhere.

However, I agree to the change to 'name[0] == 0x00'.

Ciao,
Dscho