Re: [Qemu-devel] [PATCH] block-vvfat.c - fix is_free predicate

[Johannes Schindelin]

Hi,

On Thu, 26 Jun 2008, Tristan Gingold wrote:

> On Jun 26, 2008, at 8:21 AM, Johannes Schindelin wrote:
> >This explanation is not good enough.
> >
> >According to the only documentation I had quickly at hand, Wikipedia, 
> >0x40 is an attribute for a device, which is never found on disk, 
> >especially in our implementation.  0x80 is unused.  So your "& 0xc0" 
> >check seems to be totally bogus, suggesting that we use this kind of 
> >attributes anywhere.
> >
> >However, I agree to the change to 'name[0] == 0x00'.
> 
> Ok, let's forget attributes.  Do you agree with this new one?

Yes.  Note, however, that it took me 3x as much time to save the 
attachment and look at it, than it would have taken me if you had inlined 
it.

Thanks,
Dscho