qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status info


From: Gleb Natapov
Subject: Re: [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information.
Date: Mon, 30 Jun 2008 16:26:52 +0300

On Sun, Jun 29, 2008 at 11:49:07PM +0300, Gleb Natapov wrote:
> On Sun, Jun 29, 2008 at 09:34:08PM +0100, Paul Brook wrote:
> > > The model takes into account that not all interrupt controller are
> > > capable to detect missed interrupt (it is possible that there is no
> > > interrupt controller at all). In this case irq function should
> > > return one and everything will fall back to how it works now.
> > 
> > On a related note the correct way to fix this is "-icount auto".
> > You should make sure that your hacks are not enabled when we have a 
> > realistic 
> > virtual timebase.
> > 
> Can you educate me what "-icount auto" is? Quick grep in qemu tree shows
> nothing.
> 
I forgot to rebase my branch that is why grep showed nothing ;) But
there is no much documentation about virtual time base. I can't see why
this hack cannot coexist with virtual time base. If virtual time base
somehow guaranties that interrupts will never be lost then qemu_irq_rase()
will never return zero and the hack will be as good as disabled.

--
                        Gleb.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]