[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [RESEND][PATCH] save/restore interrupt_request across s
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [RESEND][PATCH] save/restore interrupt_request across snapshots |
Date: |
Tue, 01 Jul 2008 23:47:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Paul Brook wrote:
>> Save interrupt_request state along with the cpu snapshot and restore it
>> properly. This also solves the bug that pending interrupts before
>> invocation of qemu_loadvm_state can tunnel into the resumed guest,
>> causing invalid IRQs there.
>
> I just checked in a patch which is a superset of this functionality.
Nice cleanups!
( Well, except for
if (version_id != 3 && version_id != 4 && version_id != 5
&& version_id != 6)
:-> )
And after fixing this typo, it also works nicely:
Index: exec.c
===================================================================
--- exec.c (Revision 4817)
+++ exec.c (Arbeitskopie)
@@ -463,7 +463,7 @@ static int cpu_common_load(QEMUFile *f,
return -EINVAL;
qemu_get_be32s(f, &env->halted);
- qemu_put_be32s(f, &env->interrupt_request);
+ qemu_get_be32s(f, &env->interrupt_request);
tlb_flush(env, 1);
return 0;
Jan
signature.asc
Description: OpenPGP digital signature