[Qemu-devel] Re: [PATCH 0/13] Enhance debugging support - 2nd take

[Jan Kiszka]

Jan Kiszka wrote:
> Hi,
> 
> here comes a rebased and slightly changed version of my debug patch series.
> 
> The only deeper change comes with patch 5: Instead of introducing a new
> single step mode, this patch enables pushing the TB's cflags from an
> arbitrary context into the next regular TB recompilation - without the
> need to start that compilation manually. That's a less invasive
> approach. Originally, I tried to use the cpu_io_recompile pattern for
> this, but then I realized that the scenarios are actually too different.
> 
> To summarize the major contributions of this series:
>  - Fixes and enhances host-injected watchpoint support
>  - Enhances internal debugging API
>  - Fixes SMP guest debugging
>  - Adds full support for x86 debug registers
> 

May I repeat my request for comments, suggestions, wishes regarding this
series? If there are concerns, even vague ones, please let us discuss
them. I think the last one raised by Paul should be solved by the
update I sent. If you don't think so, share your concerns.

If there are no more concern, then it would be nice to merge the series
and test things further this way. You can be sure I won't run away once
all bits are in, I'm most interested in a stable and clean solution.

See, we (CT as well as our customer) would be more happy to spend the
currently available resources on improving the patches than on
maintaining them out of tree (specifically as we need them in KVM as well).

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux