qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [4875] Remove unintended dereference, kills a warning (


From: Laurent Desnogues
Subject: Re: [Qemu-devel] [4875] Remove unintended dereference, kills a warning (Jan Kiszka).
Date: Wed, 16 Jul 2008 13:36:00 +0200

On Wed, Jul 16, 2008 at 1:31 PM, Andrzej Zaborowski <address@hidden> wrote:
>
> Modified: trunk/target-sh4/op.c
> ===================================================================
> --- trunk/target-sh4/op.c       2008-07-16 04:45:12 UTC (rev 4874)
> +++ trunk/target-sh4/op.c       2008-07-16 11:31:11 UTC (rev 4875)
> @@ -594,8 +594,8 @@
>
>  void OPPROTO op_tasb_rN(void)
>  {
> -    cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
> -    *(int8_t *) env->gregs[PARAM1] |= 0x80;
> +    cond_t((env->gregs[PARAM1] && 0xff) == 0);

Guess that should be a single '&'.

> +    *(int8_t *) &env->gregs[PARAM1] |= 0x80;
>     RETURN();
>  }

Laurent




reply via email to

[Prev in Thread] Current Thread [Next in Thread]