qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [4875] Remove unintended dereference, kills a warning (


From: Jan Kiszka
Subject: [Qemu-devel] Re: [4875] Remove unintended dereference, kills a warning (Jan Kiszka).
Date: Wed, 16 Jul 2008 14:10:01 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Laurent Desnogues wrote:
> On Wed, Jul 16, 2008 at 1:31 PM, Andrzej Zaborowski <address@hidden> wrote:
>> Modified: trunk/target-sh4/op.c
>> ===================================================================
>> --- trunk/target-sh4/op.c       2008-07-16 04:45:12 UTC (rev 4874)
>> +++ trunk/target-sh4/op.c       2008-07-16 11:31:11 UTC (rev 4875)
>> @@ -594,8 +594,8 @@
>>
>>  void OPPROTO op_tasb_rN(void)
>>  {
>> -    cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
>> -    *(int8_t *) env->gregs[PARAM1] |= 0x80;
>> +    cond_t((env->gregs[PARAM1] && 0xff) == 0);
> 
> Guess that should be a single '&'.

Oh, ooh. Yes, please fix.

Thanks,
Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]