qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump
Date: Sat, 19 Jul 2008 21:33:43 -0500
User-agent: Thunderbird 2.0.0.14 (X11/20080501)

andrzej zaborowski wrote:
2008/7/17 Anthony Liguori <address@hidden>:
From: Avi Kivity <address@hidden>
Commit 737d2050 ("Implement resolution switching in common console code")
uses qemu_console_resize() instead of dpy_resize().  This means console->ds
is examined instead of the VGA private ds, and the resize does not take place,
leading to a segfault.

Fix by modifying the DisplayState directly rather than swapping the pointer.

The screen dumping is hacky but maybe it's a good idea to keep the
hacks local to hw/vga.c, with something like the following diff.  I
think we need to fix the screen dumping globally (some graphic cards
will need fixing too).

I agree the screen dumping is pretty hacky right now. Instead of installing a new DisplayState, I've never understood why we can't just dump ds->data after an appropriate translation.

I think your patch looks better, but I can also code up a new screen dumping mechanism that doesn't take over DisplayState unless I'm missing something obvious.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]