Re: [Qemu-devel] [PATCH 1/3] Fix SDL problems with BGR displays

[Anthony Liguori]

Andreas Färber wrote:
> Hi,
>
> Am 22.07.2008 um 22:51 schrieb Anthony Liguori:
>
> > From: Avi Kivity <address@hidden>
> >
> > kvm: qemu: revert qemu's sdl.c rev 1.40
> >
> > this fixes problems with bgr displays.
>
> What problems exactly are you fixing? Could other backends such as 
> Cocoa be affected, too?

The original commit in question is 2974.  I don't have the ability to 
test Cocoa but we received a bug report about a BGR display regression 
shortly after this commit.  Reverting this particular part of the commit 
made the problem go away.  See 
http://thread.gmane.org/gmane.comp.emulators.kvm.devel/7773

Perhaps Blue Swirl can comment if reverting this part of the patch 
regresses some of the test cases he was working with when he committed 
the original patch?

Regards,

Anthony Liguori