[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Save 3MB ioport table memory
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH] Save 3MB ioport table memory |
Date: |
Wed, 23 Jul 2008 13:15:42 +0100 |
User-agent: |
KMail/1.9.9 |
On Wednesday 23 July 2008, Samuel Thibault wrote:
> static void init_ioports(void)
> {
> - int i;
>...
> - }
> }
Why are you leaving empty functions?
> +static uint32_t default_ioport_readi(int index, uint32_t address)
While the abstraction is good, I don't like the name of this function.
I'd expect this to be a direct wrapper round default_ioport_read[bwl], not
something that calls the actual IO port handler. If your patch contains no
comments then everything must be intuitive and self-explanatory. Currently it
it not.
Paul