qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] Always use nonblocking mode for qemu_chr_op


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 2/3] Always use nonblocking mode for qemu_chr_open_fd.
Date: Thu, 24 Jul 2008 13:18:13 +0200
User-agent: Thunderbird 2.0.0.14 (X11/20080501)

Samuel Thibault wrote:
> Jamie Lokier, le Thu 24 Jul 2008 10:24:03 +0100, a écrit :
>> Gerd Hoffmann wrote:
>>>   (2) Run ptys in non-blocking mode.  Drawback: we risk loosing data
>>>       in case the pty reader is slow (also when nobody is connected of
>>>       course, but that is intentional ...).
>> (4) Run ptys in non-blocking mode, but use a small output buffer in
>>     QEMU so nothing is lost.  It's not that hard.
> 
> Err, there's _already_ a small buffer in the kernel pty layer :)

Yep, one page (aka 4k on x86) in size.  Of course we can buffer in qemu
too.  That doesn't solve the fundamental issue though (unless we don't
limit the buffer size, which would be insane IMHO).

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]