[Qemu-devel] Re: [PATCH 2/3] Always use nonblocking mode for qemu_chr_open_fd.

[Anthony Liguori]

Gerd Hoffmann wrote:
>   Hi,
>
> > Which means we need our own code for ptys and can't use the generic fd
> > functions.  I'll go trying cooking up a patch ...
>
> Comments on this one?

If this is the best we can do (and I certainly hope we can do better), 
then I would at least like to see the interval bumped up to a second. 
I'd also like to see the qemu_mod_timer API extended to accept timeouts 
in milliseconds or seconds such that the later can be coalesced into a 
single wake-up.

An alternative implementation would be to use one timer for all PTY 
devices but I think adding a qemu_mod_timer_sec() is a more useful 
general thing to do.

Regards,

Anthony Liguori

> cheers,
>   Gerd