Re: [Qemu-devel] [PATCH] Add Apollon (OMAP24xx) board support

[andrzej zaborowski]

2008/7/25 Kyungmin Park <address@hidden>:
>>> @@ -3875,7 +3926,11 @@ static uint32_t omap_sdrc_read(void *opaque, 
>>> target_phys_addr_t addr)
>>>     case 0x68: /* SDRC_DLLB_CTRL */
>>>     case 0x6c: /* SDRC_DLLB_STATUS */
>>>     case 0x70: /* SDRC_POWER */
>>> +         return 0x00;
>>> +
>>>     case 0x80: /* SDRC_MCFG_0 */
>>> +         return 0x4000;
>>> +
>>
>> This should be made writable (default value is 0) and the bootloader
>> or the board file (hw/nseries.c) needs to write the correct value
>> there.
>
> Agreed, apollon and omap2420h4 read this value at bootloader, Yes it's
> meanless in qemu.
> it's seted at initial bootloader, but it's not in qemu. If sdrc has
> array value, we can read it

I mean something like

    uint32_t mcfg0 = (boot_info.ram_size / 0x200000) << 8;        /* RAMSIZE */

    cpu_physical_memory_write(0x68009080,     /* SDRC_MCFG_0 */
                    (void *) &mcfg0, sizeof(mcfg0));

>
>>
>> Would there be much redundancy if apollon setup was in a separate file?
>
> Yes, as you see almost same as n800.

It seems apollon only uses n8x0_init, n8x0_nand_setup and
n8x0_usb_setup, everything else is nseries-specific. (plus maybe the
menelaus chip on i2c)

>
>>
>> The latter two don't seem to be supported in this patch. OMAP2 on-chip
>> lcdc will require a bit of work to be usable.
>
> It's initial support we need to work more to support full peripherals.
>>
>>> address@hidden
>>> +Secure Digital card connected to OMAP MMC/SD host
>>> address@hidden
>>> +One OMAP on-chip UARTs
>>> address@hidden
>>> +External USB transceiver chip connected to USB controller embedded in a TI
>>
>> (TUSB6010 chip?)
>
> actually ISP1105W.
>
>>
>>> address@hidden
>>> +Three GPIO switches and GPIO indicate LEDs
>>
>> This isn't in the patch either.
>>
>> I'll commit the omap GPMC improvements for the moment.
>>
>
> same as above.
>
> If you don't mind I want to add mentioned devices later

You don't have to add them, but they shouldn't be listed in
qemu-doc.texi before they are supported.

Cheers,
Andrzej